[TT-13819] Benchmark updates, session limiter workaround for test goroutine leak

[titpetric]

PR Type

Enhancement, Tests

---

Description

• Added DisableRateLimit and DisableQuota flags in multiple test cases.

• Improved benchmark scripts and added skipping for specific benchmarks.

• Refactored session limiter to encourage reuse of bucketStore.

• Updated CI benchmark script for better profiling and output.

---

Changes walkthrough 📝

	Relevant files
Tests	7 files api_definition_test.go Added DisableRateLimit and DisableQuota flags in API definition tests +2/-0      event_system_test.go Added benchmark skipping for generic event handlers            +2/-0      mw_basic_auth_test.go Added `DisableRateLimit` and `DisableQuota` flags in basic auth tests +2/-1      mw_jwt_test.go Added `DisableRateLimit` and `DisableQuota` flags in JWT tests +10/-0    mw_transform_test.go Refactored transform middleware benchmarks for better structure +9/-7      oauth_manager_test.go Added benchmark skipping for OAuth token purging                  +2/-0      res_handler_header_injector_test.go Adjusted header injection benchmarks and test cases            +7/-6
Enhancement	2 files session_manager.go Refactored session limiter to reuse `bucketStore`                +4/-1      ci-benchmark.sh Enhanced CI benchmark script with profiling and output improvements +9/-3
Configuration changes	1 files CODEOWNERS Updated ownership for `/bin/` directory                                    +1/-0

---

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

[github-actions]

API Changes

no api changes detected

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪

🧪 PR contains tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Possible Resource Sharing Issue The introduction of the sessionLimiterBucketStore as a shared variable for bucketStore in NewSessionLimiter may lead to unintended side effects or resource contention if not carefully managed. Ensure thread safety and proper isolation where necessary. // Encourage reuse in NewSessionLimiter. var sessionLimiterBucketStore = memorycache.New() // NewSessionLimiter initializes the session limiter. // // The session limiter initializes the storage required for rate limiters. // It supports two storage types: `redis` and `local`. If redis storage is // configured, then redis will be used. If local storage is configured, then // in-memory counters will be used. If no storage is configured, it falls // back onto the default gateway storage configuration. func NewSessionLimiter(ctx context.Context, conf *config.Config, drlManager *drl.DRL) SessionLimiter { sessionLimiter := SessionLimiter{ ctx: ctx, drlManager: drlManager, config: conf, bucketStore: sessionLimiterBucketStore, } Benchmark Script Robustness The updated benchmark script iterates over all benchmarks and executes them with profiling enabled. Ensure that this approach handles edge cases, such as benchmarks with unexpected names or execution failures, gracefully. # Build gw test binary go test -o gateway.test -c ./gateway BENCHMARKS=$(./gateway.test -test.list=Bench.+) for benchmark in $BENCHMARKS; do echo $benchmark benchRegex="^${benchmark}$" ./gateway.test -test.run=^$ -test.bench=$benchRegex -test.count=1 -test.benchtime 10s -test.benchmem -test.cpuprofile=tyk-cpu.out -test.memprofile=mem.out -test.trace=trace.out done

[github-actions]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Possible issue	Add a nil check for tmeta and transform to prevent runtime errors during benchmarking Ensure that the transformBody function is properly tested for edge cases where tmeta or transform might be nil to avoid potential runtime panics. gateway/mw_transform_test.go [77-79] +if tmeta == nil || transform == nil { + b.Fatalf("unexpected nil value for tmeta or transform") +} if err := transformBody(r, tmeta, transform); err != nil { b.Fatalf("wanted nil error, got %v", err) } Suggestion importance[1-10]: 8 Why: Adding a nil check for tmeta and transform is a valuable enhancement to prevent potential runtime panics during benchmarking. This suggestion improves robustness and ensures the code handles edge cases effectively.	8
General	Add a check to ensure the BENCHMARKS variable is not empty before executing the loop Add error handling for the BENCHMARKS variable to ensure it is not empty before proceeding with the loop, preventing unexpected script failures. bin/ci-benchmark.sh [7-9] BENCHMARKS=$(./gateway.test -test.list=Bench.+) +if [ -z "$BENCHMARKS" ]; then + echo "No benchmarks found." + exit 1 +fi for benchmark in $BENCHMARKS; do Suggestion importance[1-10]: 7 Why: Adding a check for an empty BENCHMARKS variable is a practical improvement to prevent unexpected script failures. This enhances the script's reliability and ensures graceful handling of edge cases.	7
	Make the benchmark skipping conditional or document its purpose to avoid accidental test omissions Ensure that skipping the benchmark with b.Skip() is conditional or documented to avoid unintentionally disabling important tests. gateway/oauth_manager_test.go [1404] -b.Skip() +if shouldSkipBenchmark() { + b.Skip("Skipping benchmark due to configuration or conditions.") +} Suggestion importance[1-10]: 6 Why: Making the benchmark skipping conditional or documenting its purpose is a reasonable suggestion to avoid unintentionally disabling important tests. However, its impact is moderate as it primarily addresses clarity and intentionality rather than a critical issue.	6

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[titpetric]

/release to release-5.3

[tykbot]

Working on it! Note that it can take a few minutes.

[tykbot]

@titpetric Succesfully merged PR

[titpetric]

/release to release-5-lts

[tykbot]

Working on it! Note that it can take a few minutes.

[tykbot]

@titpetric Succesfully merged PR

[titpetric]

/release to release-5.1

[tykbot]

Working on it! Note that it can take a few minutes.

[tykbot]

@titpetric Succesfully merged PR

[titpetric]

/release to release-5.2

[tykbot]

Working on it! Note that it can take a few minutes.

[tykbot]

@titpetric Succesfully merged PR