Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

color_scheme arg is not being used #169

Open
lardcanoe opened this issue May 8, 2017 · 1 comment
Open

color_scheme arg is not being used #169

lardcanoe opened this issue May 8, 2017 · 1 comment
Assignees
Labels

Comments

@lardcanoe
Copy link

https://github.com/TwP/logging/blob/master/lib/logging.rb#L94

:color_scheme should be part of that array.

Without it I don't get colorized log output.

I'll open a PR if you agree that this is an oversight. Thanks!

@TwP
Copy link
Owner

TwP commented May 21, 2017

Ah, I see what you're saying here. As the code stands right now, you cannot add colorization to a simple Logger instance created via the Logging.logger() method. You are proposing that :color_scheme be added as an option to the method.

👍

If you would love to take a stab at implementing the functionality, then please go ahead. Pull requests are always welcome 🙇‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants