Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - S2 Clustering Min Points #122

Open
Jebula999 opened this issue Mar 28, 2023 · 3 comments
Open

Feature Request - S2 Clustering Min Points #122

Jebula999 opened this issue Mar 28, 2023 · 3 comments
Labels
enhancement New feature or request low priority

Comments

@Jebula999
Copy link

Hey there,

Small feature request.
Adding an option for the "S2" strategy in Clustering that allows for "minimum points", similar to the "Radius" method.

@Jebula999 Jebula999 changed the title Feature Request - 9x9 Clustering Min Points Feature Request - S2 Clustering Min Points Mar 28, 2023
@TurtIeSocks
Copy link
Owner

Can you elaborate what the use case for this would be? I'm under the impression that 9×9 is mostly meant for full coverage scenarios?

@Jebula999
Copy link
Author

Jebula999 commented Mar 28, 2023

I had the same impression.

However, after using it as it's currently implemented when using Clustering with the S2 Strategy, I noticed it only populates 9x9's that contain at least 1 point, which is great as it is.

I thought it might be nice to be able to up that number, for example 2, that way some 9x9's that only contain 1 Gym/Pokestop can also be omitted when bootstrapping using the same S2 strategy.

See image below showing two instances where 9x9's only cover 1 gym/Pokestop.
image

By adding in the "Minimum Points", similar to the Radius strategy, these outliers can be omitted easily.

I do realize it's a very edge-case scenario, just something I noticed while testing.

@TurtIeSocks
Copy link
Owner

I looked into this last night and realized it was unfortunately a little more complicated than I thought it would be at first glance so it will have to happen down the line.

@clburlison clburlison added enhancement New feature or request low priority labels Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority
Projects
None yet
Development

No branches or pull requests

3 participants