Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detailed Light and Heavy Bowgun stats #6

Closed
TurkeyTickle opened this issue Apr 23, 2018 · 8 comments
Closed

Add detailed Light and Heavy Bowgun stats #6

TurkeyTickle opened this issue Apr 23, 2018 · 8 comments
Labels
enhancement New feature or request

Comments

@TurkeyTickle
Copy link
Owner

Deviation and ammo types data needs to be added, and they should be displayed in tooltips and the stat sheet.

@TurkeyTickle TurkeyTickle added the enhancement New feature or request label Apr 23, 2018
@neftalimich
Copy link
Contributor

Back-end proposal

  • ammo-capacity.tsv
    mhw-builder-ammocapacity-1

  • ammo-capacity.model.ts
    mhw-builder-ammocapacity-2

  • data.service.ts
    mhw-builder-ammocapacity-3

  • view example
    I don't like it, I'm not good at designing u_U
    It would be better in a tooltip, I'll need your help to do it.
    mhw-builder-ammocapacity-4

@TurkeyTickle
Copy link
Owner Author

I think the back end changes make sense, although I would refactor the ammoCapacities lookup into a separate function to avoid as much duplicate code as possible. If you want, go ahead and submit a PR with these changes and I'll merge them into a bowgun stats branch and see if I can come up with a better way to display the ammo stats.

@TurkeyTickle
Copy link
Owner Author

Thanks for submitting the back end work. I merged into the bowgunstats branch and made a first attempt at adding it to the item tooltip. Since there is a lot of ammo data to show, I think it's important for it to take up as little space as possible especially if we put it in a tooltip. So I used a smaller font size and only show ammo types that don't have a capacity of 0 for all levels. Let me know what you think, and feel free to pull the bowgunstats branch and tweak it if you want.

ammo

@neftalimich
Copy link
Contributor

Looks great, very very great. I found all the ammo information (Kulve Taroth included). In a couple of hours I'll upload the updated file.
I think it will be necessary to create a button for the mobile version that makes this tooltip appear.

@TurkeyTickle
Copy link
Owner Author

Yeah, I think it probably makes sense to have a button or something on the right side stats section that shows ammo info in a modal or a tooltip when touched like calculations. I'll play around with that some and see what I can come up with.

@TurkeyTickle
Copy link
Owner Author

In addition to the ammo capacity table in the tooltip, I've added a few new things...

  1. Added deviation and special ammo to the weapon list
    image

  2. Added ammo capacities to the stat sheet similar to what you originally prototyped. After spending some time thinking about it, I think this is a good place to show ammo capacities because when we eventually add bowgun mods, we'll want to show modified capacities in the stat sheet while showing unmodified capacities in the item tooltip.
    image

  3. When we're missing ammo capacity data for a bowgun, a warning shows instead. Right now I'm just checking if deviation == 'NA', but we might want to do that differently.
    image

With these changes all the data from the ammo-capacities.tsv file is visible in at least one place on all screen sizes. Let me know what you think. Also, are you still planning on submitting a PR with more ammo information?

@neftalimich
Copy link
Contributor

I like it so much ❤️ . Yes I have already all ammo capacities information, I'm waiting for the merge into develop branch. I have also been thinking about adding buttons in the titles to hide the information (Attack, Defense, Skills, Ammo, Melodies, etc.) what do you think about that?

@TurkeyTickle
Copy link
Owner Author

Cool, I plan on merging to develop sometime today and to master shortly after.

I was also thinking it might be useful to add some way to collapse the stat sections on the right side. I opened #53 where we can discuss and track that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants