-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add detailed Light and Heavy Bowgun stats #6
Comments
I think the back end changes make sense, although I would refactor the ammoCapacities lookup into a separate function to avoid as much duplicate code as possible. If you want, go ahead and submit a PR with these changes and I'll merge them into a bowgun stats branch and see if I can come up with a better way to display the ammo stats. |
Thanks for submitting the back end work. I merged into the bowgunstats branch and made a first attempt at adding it to the item tooltip. Since there is a lot of ammo data to show, I think it's important for it to take up as little space as possible especially if we put it in a tooltip. So I used a smaller font size and only show ammo types that don't have a capacity of 0 for all levels. Let me know what you think, and feel free to pull the bowgunstats branch and tweak it if you want. |
Looks great, very very great. I found all the ammo information (Kulve Taroth included). In a couple of hours I'll upload the updated file. |
Yeah, I think it probably makes sense to have a button or something on the right side stats section that shows ammo info in a modal or a tooltip when touched like calculations. I'll play around with that some and see what I can come up with. |
I like it so much ❤️ . Yes I have already all ammo capacities information, I'm waiting for the merge into develop branch. I have also been thinking about adding buttons in the titles to hide the information (Attack, Defense, Skills, Ammo, Melodies, etc.) what do you think about that? |
Cool, I plan on merging to develop sometime today and to master shortly after. I was also thinking it might be useful to add some way to collapse the stat sections on the right side. I opened #53 where we can discuss and track that. |
Deviation and ammo types data needs to be added, and they should be displayed in tooltips and the stat sheet.
The text was updated successfully, but these errors were encountered: