Add Hunting Horn Melodies

[neftalimich]

I've been working on this:

what it is better to use in this case, "tsv" or json?
let me know what do you think.

[TurkeyTickle]

Looking good! In general, I've been using tsv for data that may need to be modified or added to often (weapons, armor, charms, etc) and json for data that seems relatively static and/or has a lot of description text (skills, augmentations, weapon modifiers, etc). My thinking behind that was that I wanted to be able to easily add things like armor and weapons by editing the file in Excel or something similar.

With that said, normally I would say I would use tsv for at least the melodies file, but this might be a case where json is better. Consider something like this for example:

[
    {
        "weaponId": 279,
        "notes": "p;r;b2",
        "melodies": [
            {
                "effectId": "selfImprovement",
                "notes": "p;p"
            },
            {
                "effectId": "attackUpL",
                "notes": "p;r;b2;p"
            },
            {
                "effectId": "healthBoostL",
                "notes": "r;b2;r;p"
            },
            ...
        ]
    },
    ...
]

What I like about this format is that it ties the melody and effect together more closely instead of relying on matching up indexes from the melodies and melodyEffect columns in the tsv. I also like using a string for the effect ids so you don't need to look up the id in the melody-effect file to know what it is. Using string ids like that has saved me a lot of time while adding new weapons/armor. One downside to this format is obviously that the file is going to be much larger and make page loads very slightly slower which can add up over time.

I think there are good arguments for both formats, but I guess I would probably lean towards json. I think it'll be fine either way though, so I think you should use whatever feels best to you. We can always adjust later if needed.

Just a heads up though - something I've been considering for a while is moving all the data into a sqlite db or something. I'm not sure if/when I'll get around to doing that, but the more data we add, the more sense it makes.