Re-enable numerical asserts since CI now uses Quarto 1.6 #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually the upstream issue is not fully fixed; there is a new version of QuartoNotebookRunner.jl with the fix (0.11.5) but Quarto itself needs to be updated https://github.com/quarto-dev/quarto-cli/blob/cf81582a26c4e43501f21ae5dec4d8be90acd4e3/src/resources/julia/Project.toml Blocked by upstream I guess. |
|
PRs submitted to Quarto. quarto-dev/quarto-cli#11100 and quarto-dev/quarto-cli#11101 Once that is merged and a new version released we just need to make sure that CI loads a new enough version of Quarto. |
|
Upstream has been merged, just waiting for a release |
penelopeysm
force-pushed
the
py/random
branch
from
1a60d9b to
9ce75a1
Compare
penelopeysm
force-pushed
the
py/random
branch
from
9ce75a1 to
3b78169
Compare
|
Preview the changes: https://turinglang.org/docs/pr-previews/539 |
penelopeysm
changed the title
penelopeysm
changed the title
5 tasks
penelopeysm
added a commit
that referenced
this pull request
Nov 17, 2024
* Uncomment asserts * Bump Quarto version in CI * Mention Quarto min version in README
Merged
penelopeysm
added a commit
that referenced
this pull request
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs contain some assertions to make sure that e.g. posterior predictions are numerically accurate. Due to #533 these assertions were sometimes randomly failing, and I had to comment them out to avoid spurious CI failures.
Since the upstream issue has been fixed, and a new version of Quarto that contains this bugfix released, this PR re-enables the assertions.
Closes #533.