Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Rhats show bad sample quality in several places in the documentation #569

Open
DoktorMike opened this issue Dec 17, 2024 · 2 comments · May be fixed by #570
Open

docs: Rhats show bad sample quality in several places in the documentation #569

DoktorMike opened this issue Dec 17, 2024 · 2 comments · May be fixed by #570

Comments

@DoktorMike
Copy link

As of version 0.35 the rhats in https://turinglang.org/docs/tutorials/docs-12-using-turing-guide/#sampling-from-a-conditional-distribution-the-posterior are quite problematic and I see this in many places in the Turing documentation. Given the simplicity of these models it really should be possible to get better samples than this.

I have not tried to sample them myself though. Just reporting what I see in the docs. :)

@penelopeysm penelopeysm transferred this issue from TuringLang/Turing.jl Dec 17, 2024
@yebai yebai linked a pull request Dec 17, 2024 that will close this issue
@penelopeysm
Copy link
Member

Hello! Thanks for reporting 😄 they are quite bad indeed. It's just a case of fixing the HMC parameters, or probably just using NUTS() instead.

@yebai
Copy link
Member

yebai commented Dec 17, 2024

This example illustrates how to use the most basic HMC sampler without any adaption. As @penelopeysm describes, the current HMC setup is poor, leading to poor mixing. #570 should fix this.

@penelopeysm, can you help go through all examples and create an issue for doc examples with poor mixing? I will help improve the MCMC setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants