Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify $tau$ for GLM hierarchical models standard prior #83

Closed
storopoli opened this issue Apr 6, 2023 · 0 comments · Fixed by #86
Closed

Modify $tau$ for GLM hierarchical models standard prior #83

storopoli opened this issue Apr 6, 2023 · 0 comments · Fixed by #86

Comments

@storopoli
Copy link
Member

Modify tau to be std(y) instead of mad(y).

          When trying to improve a Turing hierarchical intercept logistic model by reviewing turing_model.jl, I noticed that ``` function _model(μ_X, σ_X, prior, intercept_ranef, idx, ::Type{Bernoulli})``` 

includes a normalization on the dependent variable, which here is 0/1. It gives me an error because mad(y) in my case is 0, which messes with the hyperparameter $\tau$ for SD. I thought I'd bring it to the developers' attention.

mad_y=mad(y; normalize=true) (ln 266)

Originally posted by @jfhawkin in #21 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant