Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to SimpleVarInfo for better computational efficiency #43

Open
yebai opened this issue Feb 13, 2022 · 5 comments
Open

Switch to SimpleVarInfo for better computational efficiency #43

yebai opened this issue Feb 13, 2022 · 5 comments

Comments

@yebai
Copy link
Member

yebai commented Feb 13, 2022

SimpleVarInfo in DynamicPPL provides significant speedup over the current implementation. We should consider switching to use it once TuringLang/DynamicPPL.jl#360 is merged.

@storopoli
Copy link
Member

Does that change how we would write the model inside the @model block?

@yebai
Copy link
Member Author

yebai commented Feb 14, 2022

It should just work once the SimpleVarInfo integration with Turing is complete. But it is perhaps a good idea to test it on GLM models when it becomes available.

@storopoli
Copy link
Member

@yebai has this been already merged into Turing.jl?

@yebai
Copy link
Member Author

yebai commented Sep 5, 2022

We are very close now - only one final PR standing. Hopefully, it will get reviewed and merged this week or next.

@storopoli
Copy link
Member

Ok I subscribed to it and once it is merged and a new Turing version is tagged I will run tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants