Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrement Enzyme compatibility #58

Merged

Conversation

bauglir
Copy link

@bauglir bauglir commented May 23, 2024

It looks like the compat for Enzyme may have been incorrectly updated in the v0.2 release branch given that compatibility is still indicated to be with v0.11 on master. I'm running into a situation where I cannot resolve an environment that happens to pull in Enzyme for different packages due to this restriction.

I hope it's okay to bump this compat back down so we're able to resolve environments like this with the v0.2 release branch. I have completely dropped the v0.12 compatibility here as it's also not marked as compatible on master as mentioned above.

@Red-Portal
Copy link
Member

I actually wonder if we want to restrict the compat bound for Enzyme at all given that we don't test on Enzyme. @torfjelde How about just removing the compat bound entirely?

@bauglir
Copy link
Author

bauglir commented May 26, 2024

How about just removing the compat bound entirely?

I would be fine with either, but I'm not sure whether automerge on the General registry requires compats to be defined for weak dependencies as it does for regular dependencies. If it does, it's probably easier to maintain the compat as otherwise all releases of this package would have to get manually merged.

@Red-Portal
Copy link
Member

Okay, let me first check that.

@bauglir
Copy link
Author

bauglir commented May 27, 2024

From a quick glance at the automerge guidelines it looks like the compat requirements are (currently) only applied to strict dependencies and not to weak dependencies.

At the moment the aren't any references to weak dependencies in automerge guidelines. So it looks like it might be okay to not include a compat from that perspective at least.

@Red-Portal
Copy link
Member

I asked around, and authorities do say that compat rules are also enforced to weakdeps. So even if it is not enforced, I think just bumping the bound down would be the formal solution.

@bauglir
Copy link
Author

bauglir commented May 27, 2024

Sounds good to me.

@Red-Portal Red-Portal merged commit ae0c0f4 into TuringLang:v0.2-backport May 27, 2024
7 checks passed
@bauglir bauglir deleted the decrement-enzyme-compatibility branch May 28, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants