You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ErrorPageApplicationWrapper will (if enabled) catch application errors and (if handle_exceptions (which is default)) store them in backlash.exc_environ and backlash.exc_info where backlash TraceErrorsMiddleware can pick it up. It will catch and store no matter if backlash.TraceErrorsMiddleware actuallly is enabled. Disabling backlash with trace_errors.enable (which users might want for other reasons) will thus effectively hide application errors. That dependency will confusingly hide errors when they happen, and doesn't seem necessary.
I suggest to effectively let errorpage.handle_exceptions default to false if not using TraceErrorsMiddleware.
(In some ways it seems like it would be better have these two middlewares come in the opposite order.)
The text was updated successfully, but these errors were encountered:
ErrorPageApplicationWrapper
will (if enabled) catch application errors and (ifhandle_exceptions
(which is default)) store them inbacklash.exc_environ
andbacklash.exc_info
where backlashTraceErrorsMiddleware
can pick it up. It will catch and store no matter ifbacklash.TraceErrorsMiddleware
actuallly is enabled. Disabling backlash withtrace_errors.enable
(which users might want for other reasons) will thus effectively hide application errors. That dependency will confusingly hide errors when they happen, and doesn't seem necessary.I suggest to effectively let
errorpage.handle_exceptions
default to false if not usingTraceErrorsMiddleware
.(In some ways it seems like it would be better have these two middlewares come in the opposite order.)
The text was updated successfully, but these errors were encountered: