Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor PID Class #43

Open
pknessness opened this issue Feb 15, 2024 · 0 comments
Open

Refactor PID Class #43

pknessness opened this issue Feb 15, 2024 · 0 comments
Labels
enhancement New feature or request recruit Good for recruits

Comments

@pknessness
Copy link
Contributor

pknessness commented Feb 15, 2024

I have found a guide on making a more robust and expansive PID Class.
http://brettbeauregard.com/blog/2011/04/improving-the-beginners-pid-introduction/

This is it

The job is to improve our PID class with the guidelines in this guide, and understand why each change is being made.
This is something of a complex task.

Other things to look into are reset tiebacks, integer math, different pid forms, and using velocity instead of position (all listed at the end of the guide, and while I do not know what these are, they should be looked into to make our PID class the best it can be. There is a fairly good chance these are also all useless)

You may also want to look at taproot's PID class (UW's code)
https://github.com/uw-advanced-robotics/taproot/blob/develop/src/tap/algorithms/smooth_pid.cpp

@pknessness pknessness added enhancement New feature or request recruit Good for recruits high priority vital task labels Feb 15, 2024
@danielsanei danielsanei self-assigned this Mar 5, 2024
@pknessness pknessness removed the high priority vital task label Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request recruit Good for recruits
Projects
None yet
Development

No branches or pull requests

2 participants