Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with Java 9 and above #2

Open
goxr3plus opened this issue May 1, 2019 · 8 comments
Open

Problems with Java 9 and above #2

goxr3plus opened this issue May 1, 2019 · 8 comments

Comments

@goxr3plus
Copy link

Hello Trillarion, Automatic - Module - Name has problems with the file Name for Java 9 and above, can you please do a new release with the name.

java-vorbis-support-x. x. x

Thank you very much :)

@Trilarion
Copy link
Owner

I will have a look in the next couple of days.

@TonalidadeHidrica
Copy link

Well actually, renaming jar file is good to a certain degree from the viewpoint of following convention, but it would be far more helpful if you added an Automatic-Module-Name attribute to the JAR manifest. To do so you could add the following code into build.gradle:

jar {
    manifest {
        attributes 'Automatic-Module-Name': moduleName
    }
}

where moduleName should be replaced to certain module name for this project. Hope this will work fine but I'm not sure.

@Trilarion
Copy link
Owner

I think I got it right with the recent commits. Please let me know if everything is working for you now.

@goxr3plus
Copy link
Author

@TonalidadeHidrica Oou here you are ma bro :)

@goxr3plus
Copy link
Author

@Trilarion Now it Java9 ready but support for Java 8 dropped .... lol . Thank you by the way .

@Trilarion
Copy link
Owner

@goxr3plus Must have been carried away. Now Java 8 and 9 should both be fine.

@retropipes
Copy link

I created a fork that is fully jlink-ready. It seems jlink dislikes automatic modules greatly - all modules need to be explicitly named to function. Alas, I'm using JDK 13, so that's what I'm requiring, but I'm sure a small adjustment to the Gradle script for Java 9+ can get this working too. I'm not knowledgeable enough on Gradle to fix this within Gradle, so I made a Gradle-less solution that works just fine.

@Trilarion
Copy link
Owner

If there is time I will try it out. Ideally I would have a solution that works with Java 8 as well as with newer Javas and with all modes of packaging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants