Fix issues with <tplName>Config.cmake generation for TriBITGS TPLs from trilinos/Trilinos#9894 (#433) #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riBITSPub#299, TriBITSPub#433) Turns out some Trilinos configure scripts (including some of the ATDM Trilinos configure scripts) use arbitary linker arguments like '-mkl' that are not -L or -l. These arguments need to be moved forward on the link link in the 'all_libs' target. Since this is not very general, I added a 'NOTE' printed to STDOUT in order to warn about this. NOTE: This now allows an agument like: '-o some-name' and it will move '-o' forward and in the next commit the bare 'some-name' arg will be interepreted as a library name and be handled the same as '-l<libname>'. But obviously splitting up the arguments `-o some-name` by moving '-o' forward by itself and treating `some-name` as a link library is just wrong but I don't see how we can avoid that.
…riBITSPub#299, TriBITSPub#433) Of note: * Added unit test to make that single-char lib name like 'm' will be interepreted as a library. * The arguments '-o some-other-option' that were an error before are now allowed and '-o' is interepreted as its own link option and moved forward and 'some-other-option' is interpreted as a library name.
bartlettroscoe
force-pushed
the
433-fix-tpl-libraries-lib-linkflags
branch
from
a2500a1
to
35d82aa
Compare
The main testing.sandia.gov site seems to be having problems. Also, I want to be testing testing-dev.sandia.gov/cdash to make sure it is working.
|
Hello @marcinwrobel1986 and @mperrinel, Please do a detailed line-by-line post-merge review of this PR. This is all new code and tests started in the last few months. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix all of the issues with the TriBITS snapshot merged to Trilinos in trilinos/Trilinos#9894 as noted in #433 (as part of #299).
How was this tested?
I tested a configuration of Trilinos that used
-mkland it passed the configure and build (but had an unrelated runtime problem as per trilinos/Trilinos#10022).Tasks:
-mkl