Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pluginval silently succeeds when empty path given to --validate #143

Open
sudara opened this issue Dec 4, 2024 · 1 comment
Open

Pluginval silently succeeds when empty path given to --validate #143

sudara opened this issue Dec 4, 2024 · 1 comment

Comments

@sudara
Copy link
Collaborator

sudara commented Dec 4, 2024

Noticed this in Release, in CI:

Arc - 2024-12-04 51@2x

In Debug, it hits an assert:

➜  cmake-build-debug git:(main) ✗ ./modules/pluginval/pluginval_artefacts/Debug/pluginval.app/Contents/MacOS/pluginval --strictness-level 10 --timeout-ms 110000 --verbose --validate ""          
JUCE v8.0.4
JUCE Assertion failure in PluginTests.cpp:53
Started validating: 
Random seed: 0x26a7379
Validation started
	4 Dec 2024 10:49:55pm

Strictness level: 10
SUCCESS

In addition to the assert, it should probably emit an error message and return exit code 1.
@drowaudio
Copy link
Contributor

Agreed, if not plugins are found it should return 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sudara @drowaudio