Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing config in $PATH #19

Open
eL1x00r opened this issue Jan 29, 2024 · 1 comment
Open

Missing config in $PATH #19

eL1x00r opened this issue Jan 29, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@eL1x00r
Copy link
Contributor

eL1x00r commented Jan 29, 2024

When using npx / npm i -g or installing the library from npmjs, we got the issue of config module accessing NULL config file leading to an error.

This occurs due to config lib searching for the config file in current PWD path ( which is whatever path the shell is located at with global npmjs bin execution.

Fixes would be :

  • utilizing __filename/__dirname or relative path loading on runtime for global,
    AND
  • programmatic library usage should offer option to provide peer channel public key as parameter for initReader startup method
❯ npx trac-tap-reader
Need to install the following packages:
[email protected]
Ok to proceed? (y) y
WARNING: No configurations found in configuration directory:/Users/eL1x00r/config
WARNING: To disable this warning set SUPPRESS_NO_CONFIG_WARNING in the environment.
  _____                  ____                 ____                _
 |_   _| __ __ _  ___   / ___|___  _ __ ___  |  _ \ ___  __ _  __| | ___ _ __
   | || '__/ _` |/ __| | |   / _ \| '__/ _ \ | |_) / _ \/ _` |/ _` |/ _ \ '__|
   | || | | (_| | (__  | |__| (_) | | |  __/ |  _ <  __/ (_| | (_| |  __/ |
   |_||_|  \__,_|\___|  \____\___/|_|  \___| |_| \_\___|\__,_|\__,_|\___|_|

Protocol: Ordinals/TAP
/Users/el1x00r/.npm/_npx/d0d1003349eb1dca/node_modules/config/lib/config.js:182
    throw new Error('Configuration property "' + property + '" is not defined');
          ^
@eL1x00r eL1x00r added the bug Something isn't working label Jan 29, 2024
@eL1x00r eL1x00r self-assigned this Jan 29, 2024
@eL1x00r
Copy link
Contributor Author

eL1x00r commented Jan 29, 2024

new notice:

due to npx and npm i -g might not be running postinstall script for patching corestore bug,
we should avoid exposing a global package.json bin (!) from now.

@eL1x00r eL1x00r closed this as completed Jan 29, 2024
@eL1x00r eL1x00r reopened this Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant