-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request - Add configuration to disable passing comments #209
Comments
Do I understand you correctly that if there are no comments, with |
It does not necessarily have to be |
@SpOOnman Is this something you would consider implementing? To clarify the motivation in my team's case, our workflow uses Gerrit with the Checks plugin, with Sputnik being one of those checks. Because the plugin already surfaces results of each check in the Gerrit UI and in emails, having the additional message/email from Sputnik is unnecessary, particularly since there are no actions for the receiver to take when no violations are found. Longer term, I hope Sputnik can integrate with Gerrit's "Findings" feature to report violations, but in the meantime, having a way to disable notification on violations would help greatly in reducing inbox/comment-thread noise in our reviews. |
Thank you for reporting. I'll implement that. |
@SpOOnman have you had an opportunity to look into this request further? |
I'd like to only have comments when there are violations, but it doesn't appear there's a way to disable the passing comments.
I've tried setting
message.scorePassingComment=
in the configuration, but this is equivalent to leaving the configuration out, causing it to fall back to the default of "Perfect!"It would be great to have a configuration that allows these passing comments to be disabled entirely.
The text was updated successfully, but these errors were encountered: