Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make RandomDistribution a native type #164

Closed
gvanhoy opened this issue Jul 31, 2023 · 3 comments
Closed

Make RandomDistribution a native type #164

gvanhoy opened this issue Jul 31, 2023 · 3 comments
Labels
enhancement New feature or request
Milestone
v0.4.2

Comments

@gvanhoy
Copy link
Contributor

gvanhoy commented Jul 31, 2023 •
edited
Loading

Docstrings are rather bloated when describing what is essentially just a random distribution. We should describe this more succinctly by have a basic data type RandomDistribution that has its own documentation and implemented a general call method.
@gvanhoy gvanhoy added this to TorchSig Jul 31, 2023
@gvanhoy gvanhoy converted this from a draft issue Jul 31, 2023
@gvanhoy gvanhoy moved this to 🆕 New in TorchSig Jul 31, 2023
@gvanhoy gvanhoy added this to the v0.5.0 milestone Jul 31, 2023
@gvanhoy gvanhoy modified the milestones: v0.5.0, v0.4.2 Aug 22, 2023
@gvanhoy
Copy link
Contributor Author

gvanhoy commented Aug 22, 2023

Currently the random distribution also slows many things down. It should be made into a class variable

@gvanhoy gvanhoy added the enhancement New feature or request label Aug 22, 2023
@gvanhoy
Copy link
Contributor Author

gvanhoy commented Sep 5, 2023

Closed by #202

@gvanhoy gvanhoy moved this from 🆕 New to ✅ Done in TorchSig Sep 5, 2023
@MattCarrickPL
Copy link
Collaborator

Old issue, closing out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
No open projects
TorchSig
Archived in project
Milestone
v0.4.2
Development

When branches are created from issues, their pull requests are automatically linked.

164-make-randomdistribution-a-native-type TorchDSP/torchsig
2 participants
@gvanhoy @MattCarrickPL