Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using include does not respect subfolders #71

Open
DavidBrainard opened this issue Apr 10, 2017 · 1 comment
Open

Using include does not respect subfolders #71

DavidBrainard opened this issue Apr 10, 2017 · 1 comment

Comments

@DavidBrainard
Copy link
Collaborator

It seems that if I (e.g.) specify the BrainardLabToolbox as include record, the subfolder list is not respected -- I get the whole thing. I have to specify the git type and URL to get the subfolder list to be used.

It isn't entirely clear what the precedence order ought to be in the include case (the subfolders specified in the included record, or those in the record asking for the include), so maybe the current behavior is the most reasonable. But in most use cases I can think of, I'd want the subfolders in the included record to rule.

@JorisVincent
Copy link
Contributor

Pull request #84 partly fixes this: it at least respects the subfolder list specified in the record of the included toolbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants