Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-parentFrame is a private API #2

Open
ItalyPaleAle opened this issue Jan 16, 2015 · 5 comments
Open

-parentFrame is a private API #2

ItalyPaleAle opened this issue Jan 16, 2015 · 5 comments

Comments

@ItalyPaleAle
Copy link

My app got rejected by the static analyzer for using this method because -parentFrame is a private API.

I managed to solve that by checking on the delegate if the jsContext that's passed is the same as the context for the main frame:

- (void)didCreateJavaScriptContext:(JSContext *)jsContext
{
    // Get the context for the main frame and verify it's the same
    JSContext *mainFrameCtx = [self valueForKeyPath:@"documentView.webView.mainFrame.javaScriptContext"];
    if(jsContext == mainFrameCtx) {
        // Call the delegate
        if(self.delegate && [self.delegate respondsToSelector: @selector(webView:didCreateJavaScriptContext:)] ) {
            [(id<TSWebViewDelegate>)self.delegate webView:self didCreateJavaScriptContext:jsContext];
        }
    }
    else {
        NSLog(@"JavaScript contexts are different");
    }
}

By using the delegate method, we're still sure that the JSContext object is created when we ask for it.

@vitock
Copy link

vitock commented Sep 7, 2015

@EgoAleSum

-[NSObject webView:didCreateJavaScriptContext: ]

I think this method is private Api too.I cant find the method in any ios document. :(

@matt-curtis
Copy link

I think this method is private Api too.I cant find the method in any ios document. :(

It's not a 'private' API per-say, it's just not exposed. It is apart of the WebFrameLoadDelegate protocol, which originates on OSX. This makes sense if you consider the fact that UIWebView is an iOS wrapper around the OSX Class WebView. https://developer.apple.com/library/mac/documentation/Cocoa/Reference/WebKit/Protocols/WebFrameLoadDelegate_Protocol/

@liyuunxiangGit
Copy link

Your app uses or references the following non-public APIs:

parentFrame

The use of non-public APIs is not permitted on the App Store because it can lead to a poor user experience should these APIs change.

@feilongOnMoudu
Copy link

I hope that we do not use this library, the bloody lessons.

2016年9月1日 上午1:22
发件人 Apple
Performance - 2.5.1

Your app uses or references the following non-public APIs:

"parentFrame"

The use of non-public APIs is not permitted on the App Store because it can lead to a poor user experience should these APIs change.

@feilongOnMoudu
Copy link

坑死我了 被拒两次

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants