Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: friend requests with very long messages are no longer dropped #2720

Merged
merged 2 commits into from
Nov 28, 2024

test: friend request test now tests min/max message sizes

29d1043
Select commit
Loading
Failed to load commit list.
Merged

fix: friend requests with very long messages are no longer dropped #2720

test: friend request test now tests min/max message sizes
29d1043
Select commit
Loading
Failed to load commit list.
Mergeable / Mergeable succeeded Nov 28, 2024 in 5s

3 checks passed!

Status: PASS

Details

✔️ Validator: TITLE

  • ✔️ All the requisite validations passed for 'or' option
    Input : fix: friend requests with very long messages are no longer dropped
    Settings : {"or":[{"must_include":{"regex":"^(feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\([^) ]+\\))?:\\ .+$","message":"Semantic release conventions must be followed."}},{"must_include":{"regex":"^Bump [^ ]* from [^ ]* to [^ ]*$","message":"Dependabot PRs are exempt from semantic release conventions."}}]}

✔️ Validator: COMMIT

  • ✔️ Your commit messages met the specified criteria
    Input : fix: friend requests with very long messages are no longer dropped

This is a band-aid solution that prevents friend requests with
long messages from being dropped. However it doesn't solve the
underlying problem, described here:
#2719: friend request test now tests min/max message sizes
Settings : {"do":"commit","message":{"regex":"^((feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\([^) ]+\\))?:\\ .+|Bump [^ ]* from [^ ]* to [^ ]*)","message":"Semantic release conventions must be followed."}}

✔️ Validator: DESCRIPTION

  • ✔️ description must exclude '\[ \]'
    Input : This is a band-aid solution that prevents friend requests with long messages from being dropped. However it doesn't solve the underlying problem, described here: #2719

This change is Reviewable

Settings : {"must_exclude":{"regex":"\\\\[ \\\\]","message":"There are incomplete TODO task(s) unchecked."}}