refactor: Make add_to_list non-recursive. #2688
Open
+28
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2688 +/- ##
==========================================
- Coverage 73.06% 73.04% -0.02%
==========================================
Files 149 149
Lines 30517 30528 +11
==========================================
+ Hits 22297 22300 +3
- Misses 8220 8228 +8 ☔ View full report in Codecov by Sentry. |
iphydf
force-pushed
the
nonrec-add_to_list
branch
from
a20503f
to
ef2ff3c
Compare
iphydf
force-pushed
the
nonrec-add_to_list
branch
from
ef2ff3c
to
c185481
Compare
github-actions
bot
added
the
refactor
iphydf
force-pushed
the
nonrec-add_to_list
branch
from
c185481
to
fffc249
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review very carefully.
This change is