Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid memcpy-ing structs into onion ping id data. #2687

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

fix: Avoid `memcpy`-ing structs into onion ping id data.

0f72a4c
Select commit
Loading
Failed to load commit list.
Open

fix: Avoid memcpy-ing structs into onion ping id data. #2687

fix: Avoid `memcpy`-ing structs into onion ping id data.
0f72a4c
Select commit
Loading
Failed to load commit list.
Mergeable / Mergeable succeeded Nov 27, 2024 in 0s

3 checks passed!

Status: PASS

Details

✔️ Validator: TITLE

  • ✔️ All the requisite validations passed for 'or' option
    Input : fix: Avoid memcpy-ing structs into onion ping id data.
    Settings : {"or":[{"must_include":{"regex":"^(feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\([^) ]+\\))?:\\ .+$","message":"Semantic release conventions must be followed."}},{"must_include":{"regex":"^Bump [^ ]* from [^ ]* to [^ ]*$","message":"Dependabot PRs are exempt from semantic release conventions."}}]}

✔️ Validator: COMMIT

  • ✔️ Your commit messages met the specified criteria
    Input : fix: Avoid memcpy-ing structs into onion ping id data.

Although it is only ever read back on the machine it originated from,
it's bad practice and we should not make our protocol have
system-specific undefined padding bytes in it.
Settings : {"do":"commit","message":{"regex":"^((feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\([^) ]+\\))?:\\ .+|Bump [^ ]* from [^ ]* to [^ ]*)","message":"Semantic release conventions must be followed."}}

✔️ Validator: DESCRIPTION

  • ✔️ description must exclude '\[ \]'
    Input : Although it is only ever read back on the machine it originated from, it's bad practice and we should not make our protocol have system-specific undefined padding bytes in it.

Found by TokTok/hs-tokstyle#252


This change is Reviewable

Settings : {"must_exclude":{"regex":"\\\\[ \\\\]","message":"There are incomplete TODO task(s) unchecked."}}