Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle fix: Ensure we have allocators available for the error paths. #2409

Closed
wants to merge 4 commits into from

Conversation

restyled-io[bot]
Copy link

@restyled-io restyled-io bot commented Sep 11, 2023

A duplicate of #2408 with additional commits that automatically address
incorrect style, created by Restyled.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

  • black
  • yapf

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Expand for example instructions
    ```console
    git remote add upstream https://github.com/TokTok/c-toxcore.git
    git fetch upstream pull/<this PR number>/head
    git merge --ff-only FETCH_HEAD
    git push
    ```
    

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.


This change is Reviewable

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.15% ⚠️

Comparison is base (0cef46e) 74.66% compared to head (234b336) 74.52%.

❗ Current head 234b336 differs from pull request most recent head f729b7f. Consider uploading reports for the commit f729b7f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2409      +/-   ##
==========================================
- Coverage   74.66%   74.52%   -0.15%     
==========================================
  Files          87       87              
  Lines       26190    26192       +2     
==========================================
- Hits        19555    19519      -36     
- Misses       6635     6673      +38     
Files Changed Coverage Δ
toxcore/group_chats.c 69.96% <100.00%> (-0.60%) ⬇️
toxcore/network.c 86.09% <100.00%> (ø)

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@restyled-io restyled-io bot force-pushed the restyled/pull-2408 branch from 234b336 to f729b7f Compare September 11, 2023 11:59
@restyled-io restyled-io bot closed this Sep 11, 2023
@restyled-io restyled-io bot deleted the restyled/pull-2408 branch September 11, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants