Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the handling of special disabled features #1162

Open
Alathreon opened this issue Sep 2, 2024 · 0 comments
Open

Improve the handling of special disabled features #1162

Alathreon opened this issue Sep 2, 2024 · 0 comments
Assignees
Labels
config-changes if your PR contains any changes related to config file enhancement New feature or request

Comments

@Alathreon
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Disabled features have two cases, normal features and special features. Special features are disabled with a string, which can be anything (usually a string representation of the class). But it is also error prone and not very good with features that are shared by several classes.

Describe the solution you'd like

Special features will now use an enum that will be filled with features.

Note that it will require to update the config for the special features (or the special features will be turned on, or the config parsing will crash).

Describe alternatives you've considered

Additional context

@Alathreon Alathreon added enhancement New feature or request config-changes if your PR contains any changes related to config file labels Sep 2, 2024
@Alathreon Alathreon self-assigned this Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config-changes if your PR contains any changes related to config file enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant