Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

registerSave callback should run when setting is changed on another device #26

Open
tdulcet opened this issue Aug 31, 2022 · 0 comments

Comments

@tdulcet
Copy link

tdulcet commented Aug 31, 2022

The registerSave callback should run when a setting is changed on another browser instance or device, so that it could be automatically applied as suggested on the README:

It is thus quite useful to automatically apply the option or send it to other parts of the browser extension, so they are notified that a the value of the option changed. This is a useful feature for your usability, because the AutomaticSetings module automatically saves all options, so they should also automatically be applied, so the user immediately sees the difference.

Currently the user would need to manually restart their browser for any changes to take effect.

This library could use the storage.onChanged event or with Firefox/Thunderbird 101 or greater, the storage.sync.onChanged event and then call the respective registerSave callbacks based on the changes argument.

Note that syncing is not currently supported by Firefox for Android (Bug 1595822) or Thunderbird (Bug 1427501).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant