Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localized strings do not have fallbacks #25

Open
tdulcet opened this issue Aug 25, 2022 · 0 comments
Open

Localized strings do not have fallbacks #25

tdulcet opened this issue Aug 25, 2022 · 0 comments

Comments

@tdulcet
Copy link

tdulcet commented Aug 25, 2022

This library uses several localized strings to display messages to the user using the MessageHandler library. For example:

() => CommonMessages.showSuccess("resettingOptionsWorked", true, {

However, it does not provide any fallbacks for extensions that are not (yet) localized, which causes the raw camel case message names to be shown instead:
image

While still readable, this obviously provides a very poor UX. This currently affects all six of my add-ons that are not yet localized. I would obviously love for all of them to be localized (PRs welcome), but that is of course an extremely time consuming and tedious process...

The fact that this library requires localization it also not documented on the README or in any of the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant