Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove time from MergeBatcher #550

Merged

Conversation

antiguru
Copy link
Member

@antiguru antiguru commented Dec 7, 2024

We can use the time declared by the Merger direction, which always needs to equal the time on MergeBatcher's Batcher implementation.

We can use the time declared by the Merger direction, which always needs to
equal the time on MergeBatcher's Batcher implementation.

Signed-off-by: Moritz Hoffmann <[email protected]>
Copy link
Member

@frankmcsherry frankmcsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@frankmcsherry frankmcsherry merged commit daae392 into TimelyDataflow:master Dec 7, 2024
7 checks passed
@github-actions github-actions bot mentioned this pull request Dec 6, 2024
@antiguru antiguru deleted the merge_batcher_no_time branch December 7, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants