Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Attack contract for testing, merge NFTTracker contract into Staking #31

Open
Hamedblue1381 opened this issue May 2, 2024 · 0 comments · May be fixed by #32
Open

Add Attack contract for testing, merge NFTTracker contract into Staking #31

Hamedblue1381 opened this issue May 2, 2024 · 0 comments · May be fixed by #32
Assignees
@Hamedblue1381

Comments

@Hamedblue1381
Copy link
Member

Description:
Add Attack contract for testing, merge NFTTracker contract into Staking

Removed:
Tracker.sol
cachedPrices (its already stored in prices storage, caching is unnecessary)
allows the owner to call the setPrices function on the nftTracker test case

Changes:
Added setPrice and getPrice to Staking

Test cases added:
rejects non-owner calls

Proposed Solution:
Please review the changes made and ensure they address the missing parameters and types.
@Hamedblue1381 Hamedblue1381 self-assigned this May 2, 2024
@Hamedblue1381 Hamedblue1381 linked a pull request May 2, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Hamedblue1381 Hamedblue1381

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add attack contract remove tracker 31 TimeleapLabs/unchained-lpos
1 participant
@Hamedblue1381