Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Expose Quarkus build item representing either the SolverConfig or the ConstraintMetaModel #1323

Open
rsynek opened this issue Jan 14, 2025 · 0 comments · May be fixed by #1343
Open

Feat: Expose Quarkus build item representing either the SolverConfig or the ConstraintMetaModel #1323

rsynek opened this issue Jan 14, 2025 · 0 comments · May be fixed by #1343
Assignees
Labels
enhancement New feature or request process/needs triage Requires initial assessment of validity, priority etc.
Milestone

Comments

@rsynek
Copy link
Contributor

rsynek commented Jan 14, 2025

To get the ConstraintMetaModel at build time in a Quarkus extension, it is necessary to depend on the solver-quarkus extension and its SolverConfigBuildItem.

While depending on other extension's build item(s) is the way collaboration between extensions has been designed in Quarkus, it's a weak dependency: there is no guarantee of the build item to be still produced by the upstream extension or its class being still present in a compatible way.

Proposal:

  • move the SolverConfigBuildItem to an api subpackage
  • configure Revapi to make sure we don't break it
  • as an alternative, expose a build item representing the ConstraintMetaModel
@rsynek rsynek added enhancement New feature or request process/needs triage Requires initial assessment of validity, priority etc. labels Jan 14, 2025
@rsynek rsynek self-assigned this Jan 14, 2025
@triceo triceo added this to the v1.19.0 milestone Jan 15, 2025
@rsynek rsynek linked a pull request Jan 21, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request process/needs triage Requires initial assessment of validity, priority etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants