From 813d1714d4328ac13ddfc268cd022b8d3f70b439 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Luk=C3=A1=C5=A1=20Petrovick=C3=BD?= Date: Thu, 3 Oct 2024 15:01:54 +0200 Subject: [PATCH] Adjust cron --- .../nightly_performance_score_director.yml | 14 ++++++++++++-- .github/workflows/performance_score_director.yml | 3 +-- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/.github/workflows/nightly_performance_score_director.yml b/.github/workflows/nightly_performance_score_director.yml index 1344aba4..351e4a06 100644 --- a/.github/workflows/nightly_performance_score_director.yml +++ b/.github/workflows/nightly_performance_score_director.yml @@ -2,13 +2,23 @@ name: Schedule a nightly run of the Score Director performance benchmark on: schedule: - - cron: '0 0 * * *' # Every day at the start of the day + - cron: '59 23 * * 1-5' # Every workday at the end of the day. jobs: trigger: runs-on: ubuntu-latest steps: + - name: Checkout timefold-solver + uses: actions/checkout@v4 + with: + repository: TimefoldAI/timefold-solver - name: Schedule the other workflow shell: bash run: | - echo '{}' | gh workflow run performance_score_director.yml --json \ No newline at end of file + if git log --since="24 hours ago" --oneline | grep -q .; then + echo '{}' | gh workflow run performance_score_director.yml --json + echo "Launched nightly perf tests." >> $GITHUB_STEP_SUMMARY + else + # Don't waste money. + echo "No commits in the past 24 hours." >> $GITHUB_STEP_SUMMARY + fi diff --git a/.github/workflows/performance_score_director.yml b/.github/workflows/performance_score_director.yml index 2383fde6..cfd28b23 100644 --- a/.github/workflows/performance_score_director.yml +++ b/.github/workflows/performance_score_director.yml @@ -2,8 +2,7 @@ # - The baseline is established first, then the branch under test is measured. # - Each benchmark gives a 99.9 % confidence interval. # - The confidence intervals are compared to determine if the branch under test is a regression or an improvement. -# - The error threshold is expected to be below +/- 2.5 %, -# but sometimes it gets higher due to the nature of public GitHub runners. +# - The error threshold is expected to be below +/- 2.5 %. # We have yet to see an error of over +/- 4 %. # With the error so high, the impact is that small regressions are not considered statistically significant. name: Performance Regression Test - Score Director