From 14cae1f02bae1d13aa1b5398c9038c24220e3a9b Mon Sep 17 00:00:00 2001
From: Agisilaos Kounelis <36283973+kounelisagis@users.noreply.github.com>
Date: Mon, 14 Oct 2024 23:18:13 +0300
Subject: [PATCH] Fix randomly failing test
 `DenseArrayTest::test_open_with_timestamp[False]` (#2090)

---
 tiledb/tests/test_libtiledb.py | 21 +++++++--------------
 1 file changed, 7 insertions(+), 14 deletions(-)

diff --git a/tiledb/tests/test_libtiledb.py b/tiledb/tests/test_libtiledb.py
index a0e40b9600..9122ad0f7e 100644
--- a/tiledb/tests/test_libtiledb.py
+++ b/tiledb/tests/test_libtiledb.py
@@ -836,9 +836,7 @@ def test_open_with_timestamp(self, use_timestamps):
         with tiledb.DenseArray(self.path("foo"), mode="w") as T:
             T[:] = A
 
-        read1_timestamp = -1
         with tiledb.DenseArray(self.path("foo"), mode="r") as T:
-            read1_timestamp = T.timestamp_range
             self.assertEqual(T[0], 0)
             self.assertEqual(T[1], 0)
             self.assertEqual(T[2], 0)
@@ -849,25 +847,20 @@ def test_open_with_timestamp(self, use_timestamps):
         with tiledb.DenseArray(self.path("foo"), mode="w") as T:
             T[0:1] = 1
 
-        read2_timestamp = -1
-        with tiledb.DenseArray(self.path("foo"), mode="r") as T:
-            read2_timestamp = T.timestamp_range
-            self.assertTrue(read2_timestamp > read1_timestamp)
-
         if use_timestamps:
             # sleep 200ms and write
             time.sleep(0.2)
         with tiledb.DenseArray(self.path("foo"), mode="w") as T:
             T[1:2] = 2
 
-        read3_timestamp = -1
-        with tiledb.DenseArray(self.path("foo"), mode="r") as T:
-            read3_timestamp = T.timestamp_range
-            self.assertTrue(read3_timestamp > read2_timestamp > read1_timestamp)
+        frags = tiledb.array_fragments(self.path("foo"))
+        # timestamps are in the form of (start, end) for each fragment, with start == end,
+        # as we are not dealing with consolidated fragments. Let's simply read from 0 to the end timestamp.
+        read_timestamps = [(0, frag.timestamp_range[1]) for frag in frags]
 
         # read at first timestamp
         with tiledb.DenseArray(
-            self.path("foo"), timestamp=read1_timestamp, mode="r"
+            self.path("foo"), timestamp=read_timestamps[0], mode="r"
         ) as T:
             self.assertEqual(T[0], 0)
             self.assertEqual(T[1], 0)
@@ -875,7 +868,7 @@ def test_open_with_timestamp(self, use_timestamps):
 
         # read at second timestamp
         with tiledb.DenseArray(
-            self.path("foo"), timestamp=read2_timestamp, mode="r"
+            self.path("foo"), timestamp=read_timestamps[1], mode="r"
         ) as T:
             self.assertEqual(T[0], 1)
             self.assertEqual(T[1], 0)
@@ -883,7 +876,7 @@ def test_open_with_timestamp(self, use_timestamps):
 
         # read at third timestamp
         with tiledb.DenseArray(
-            self.path("foo"), timestamp=read3_timestamp, mode="r"
+            self.path("foo"), timestamp=read_timestamps[2], mode="r"
         ) as T:
             self.assertEqual(T[0], 1)
             self.assertEqual(T[1], 2)