math bug?

[sneak]

I added a test, I think the calculation you're using is incorrect?

func FromUnixMilli(ms int64) time.Time {
	return time.Unix(ms/int64(millisInSecond), (ms%int64(millisInSecond))*int64(nsInSecond))
}

I don't think you get the integer nanoseconds portion by doing (ms%int64(millisInSecond))*int64(nsInSecond). I used this and got some incorrect results.

Test (failing) is here:

https://github.com/Tigraine/go-timemilli/pull/3/files

[lss4]

Just tried. It's working as intended. That test failed because the timestamp returned by time.Now() has a higher precision.

Though I do agree the name of the const, nsInSecond, is not correct here. It should be nsInMillisecond.