You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't think missingstring always needs to be a string for all read functions, which can make the name confusing. I would consider renaming it to missing_value. For the read functions that require a string, we can always convert it to a string in the read_* function or set a type restriction in the arguments.
It's not as easy as doing a find-replace because the CSV.jl package uses the missingstring argument.
The text was updated successfully, but these errors were encountered:
The big difference is that for read_xlsx is that it mixes types ie missing_value = ["string", 44] verses the CSV.jl supported functions are written missing_value = ["string", "44"] but I can figure out a way to to change this.
I think minor differences in the supported options are okay if the underlying packages we are wrapping have slight differences. We'll just make sure to document this in the docstrings.
I don't think
missingstring
always needs to be a string for all read functions, which can make the name confusing. I would consider renaming it tomissing_value
. For the read functions that require a string, we can always convert it to a string in the read_* function or set a type restriction in the arguments.It's not as easy as doing a find-replace because the CSV.jl package uses the
missingstring
argument.The text was updated successfully, but these errors were encountered: