-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roadmap #1
Comments
hey @kdpsingh I cranked thru a good amount of the file types. before i get started working on docs/docstrings, i was wondering if u wanted them to have https get support for online data(readr does for csv/tsv/delim). i have one for csv and it would be p easy to do, but i thought id get your take first as it would add one more dependency to the package. happy either way. Also lmk if ive missed any key types to get up and running for the v.1 |
Adding a dependency is fine if it means we can read in files from the web in all of the above formats. |
Would also love to add support for all formats supported in the haven R package (eg SAS and Stata files) |
adding support for SAS and Stata files is no problem. The ReadStatTables.jl package made it ridiculously easy. so i already have support for all of them. The package made it so the underlying function is identical |
Great question! Let me think about this. |
Here's my idea: Let's make specific function names to match the extension (read_sas, etc). At some later point, we may also add a single read_file() and write_file() function that infers the correct extension and calls the correct function specific to that extension. |
sounds good. this repo might be nearly ready! Just need to pkg template it and make sure docstrings run |
I know its Monday and as a gainfully employed person, I assume you are busy but a quick update: Doctests clock in locally at 39.7s. I pared that down from 50, but I was unable to drop it further. Open to suggestions. Files are in place for documentation, with a brief index.md written. The only thing, when i was going thru the pkgtemplate.jl prompts I must have missed setting up the github tests? so theyre not running online. I am not sure how to enable that. Otherwise, I think this should be ready for transfer to TidierOrg / head to registry
|
Amazing. I can help figure out the GitHub tests (need to set up GitHub actions). Don't worry about the test completion time. 40 seconds is totally fine. Can you move this repo over to TidierOrg? |
That would be awesome thank you! Just transferred it |
11/11 on checklist. I'll go ahead and close this. |
fwf
helper functions to include nameThe text was updated successfully, but these errors were encountered: