Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding TidierVest.jl #121

Closed
kdpsingh opened this issue Sep 11, 2023 · 6 comments
Closed

Adding TidierVest.jl #121

kdpsingh opened this issue Sep 11, 2023 · 6 comments

Comments

@kdpsingh
Copy link
Member

I am planning to add TidierVest.jl as a dependency to Tidier.jl so that it gets automatically installed when you install Tidier.jl (similar to how tidyverse works).

However, in R's tidyverse, rvest isn't automatically re-exported into the namespace. I'm thinking we may diverge from that behavior in Tidier.jl and re-export all base packages. If a user is truly using Tidier.jl, then we should make sure that all of the underlying package functions are available to them so they don't have to keep track of this behavior.

If anyone disagrees with this approach, feel free to share thoughts here.

@jdiaz97, let me know if you have any thoughts on this. Thanks!

@kdpsingh
Copy link
Member Author

@rdboyes any thoughts on this?

@rdboyes
Copy link
Member

rdboyes commented Sep 26, 2023

I think the expectation as a user would be that Tidier makes all Tidier*** packages available, so it makes sense to include TidierVest. People with specific requirements can import package-by-package

@kdpsingh
Copy link
Member Author

Perfect. Agree that this makes the most sense.

I'll plan to add TidierVest while also bumping the dependency versions of all the other packages. This way, updating Tidier will ensure that all the base packages get updated to their latest versions.

@micke754
Copy link

Just an average R Tidyverse user (for work) and fully agree with your approach of including TidierVest.jl within Tidier.jl. We're used to the practice importing the Tidyverse as a whole when you start a project and then narrowing down the imports later on when finishing things up.

@kdpsingh
Copy link
Member Author

Thanks @micke754 for sharing that perspective! Have been busy with work, going to take care of this soon.

@kdpsingh
Copy link
Member Author

TidierVest.jl is now included with Tidier.jl, so closing this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants