-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider splitting out !-notation into separate repo? #66
Comments
They are separate artifacts but not separate repositories at the moment. |
The current code base is modular at the artifact level. Most of keywords depend on only the core |
Yes I suggest independent repos.
Finagle was similar to your layout. Independent artifacts, one repo and a
master build.sbt. we depended only on 1 of 20 pieces, but had to wait
6-9months for all 19 others to Support scala 2.11.
That's why I distrust large multi project repos now.
Your DSL project could suffer the same problem with 2.13 for example
…On Fri., 30 Mar. 2018, 12:37 pm 杨博 (Yang Bo), ***@***.***> wrote:
They are separate artifacts but not separate repositories at the moment.
Do you suggest to split them into different repository?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#66 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAF05GkaDXRjhjyqjT0FTNjBbHBuLlvjks5tjYxYgaJpZM4TBJTP>
.
|
If I understand correctly, the actual need is separating version number. |
What Im after is "confidence that the libraries I depend upon will be not entangled with unrelated code or concerns." That's broader than just a technical concern, it also touches on project culture & human behavior. I feel that many aspects of multiple-projects-in-single-repo encourage entanglement, and its only through careful discipline that unrelated libraries in same repo can remain modular. Examples of issues:
While many of these can be overcome, the defaults for a github repo all encourage entanglement. |
Fair enough! However multiple of repositories also means multiple of efforts to maintain those repositories. Would you like to be a maintainer of some of the split projects? |
I'm happy to help maintain repos for tools/libraries that I use ongoing. At
this point, Im wanting to trial the use of the monadic !-operator, so Im
not yet sure if I will adopt it. How about I trial it and then respond
back..
…On Fri, Mar 30, 2018 at 7:34 PM, 杨博 (Yang Bo) ***@***.***> wrote:
Fair enough! However multiple repositories also means multiple of efforts
to maintain those repositories.
Would you like to be a maintainer of some of the split projects?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#66 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAF05Bib8LKqnSW1gbi6MeVJBeMM02Z1ks5tje4hgaJpZM4TBJTP>
.
|
Really nice to hear that! Do you have any plan?
2018-03-30 21:46 GMT+08:00 Ben Hutchison <[email protected]>:
… I'm happy to help maintain repos for tools/libraries that I use ongoing. At
this point, Im wanting to trial the use of the monadic !-operator, so Im
not yet sure if I will adopt it. How about I trial it and then respond
back..
On Fri, Mar 30, 2018 at 7:34 PM, 杨博 (Yang Bo) ***@***.***>
wrote:
> Fair enough! However multiple repositories also means multiple of efforts
> to maintain those repositories.
>
> Would you like to be a maintainer of some of the split projects?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#66 (comment)-
377478105>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/
AAF05Bib8LKqnSW1gbi6MeVJBeMM02Z1ks5tje4hgaJpZM4TBJTP>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#66 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAktujEmTkWk09qnuJcDFbuP6qvSkvqwks5tjjctgaJpZM4TBJTP>
.
--
Regards,
*杨博 Yang Bo*
*Consultant, ThoughtWorks*
[image: ThroughtWorks]
<https://www.thoughtworks.com/profiles/yang-bo-yangbo>
<https://github.com/Atry> [image: Blog]
<http://www.ac.net.blog.163.com/> [image:
知乎] <https://www.zhihu.com/people/atry>
|
I have some Eff-centric codebases where I'll try introducing the monadic
operator. I'll probably decide within a month whether it's something to
continue with.I'll aim to provide some feedback by end of April.
On Mon, Apr 2, 2018 at 2:36 AM, 杨博 (Yang Bo) <[email protected]>
wrote:
… Really nice to hear that! Do you have any plan?
2018-03-30 21:46 GMT+08:00 Ben Hutchison ***@***.***>:
> I'm happy to help maintain repos for tools/libraries that I use ongoing.
At
> this point, Im wanting to trial the use of the monadic !-operator, so Im
> not yet sure if I will adopt it. How about I trial it and then respond
> back..
>
> On Fri, Mar 30, 2018 at 7:34 PM, 杨博 (Yang Bo) ***@***.***>
> wrote:
>
> > Fair enough! However multiple repositories also means multiple of
efforts
> > to maintain those repositories.
> >
> > Would you like to be a maintainer of some of the split projects?
> >
> > —
> > You are receiving this because you authored the thread.
> > Reply to this email directly, view it on GitHub
> > <#66 (comment)-
> 377478105>,
> > or mute the thread
> > <https://github.com/notifications/unsubscribe-auth/
> AAF05Bib8LKqnSW1gbi6MeVJBeMM02Z1ks5tje4hgaJpZM4TBJTP>
> > .
> >
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#66 (comment)-
377527357>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/
AAktujEmTkWk09qnuJcDFbuP6qvSkvqwks5tjjctgaJpZM4TBJTP>
> .
>
--
Regards,
*杨博 Yang Bo*
*Consultant, ThoughtWorks*
[image: ThroughtWorks]
<https://www.thoughtworks.com/profiles/yang-bo-yangbo>
<https://github.com/Atry> [image: Blog]
<http://www.ac.net.blog.163.com/> [image:
知乎] <https://www.zhihu.com/people/atry>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#66 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAF05PgULRLdhkxgOHc5vwvq5n4ODWVhks5tkQIDgaJpZM4TBJTP>
.
|
Cool. Enjoy it.
You may also consider directly creating some Dsl type class instead Monad.
The Dsl type class can interpret keywords, similar to Free monads, except Dsl is
open for extending while Free monads are sealed.
2018-04-02 7:34 GMT+08:00 Ben Hutchison <[email protected]>:
… I have some Eff-centric codebases where I'll try introducing the monadic
operator. I'll probably decide within a month whether it's something to
continue with.I'll aim to provide some feedback by end of April.
On Mon, Apr 2, 2018 at 2:36 AM, 杨博 (Yang Bo) ***@***.***>
wrote:
> Really nice to hear that! Do you have any plan?
>
> 2018-03-30 21:46 GMT+08:00 Ben Hutchison ***@***.***>:
>
> > I'm happy to help maintain repos for tools/libraries that I use
ongoing.
> At
> > this point, Im wanting to trial the use of the monadic !-operator, so
Im
> > not yet sure if I will adopt it. How about I trial it and then respond
> > back..
> >
> > On Fri, Mar 30, 2018 at 7:34 PM, 杨博 (Yang Bo) <
***@***.***>
> > wrote:
> >
> > > Fair enough! However multiple repositories also means multiple of
> efforts
> > > to maintain those repositories.
> > >
> > > Would you like to be a maintainer of some of the split projects?
> > >
> > > —
> > > You are receiving this because you authored the thread.
> > > Reply to this email directly, view it on GitHub
> > > <https://github.com/ThoughtWorksInc/Dsl.scala/
issues/66#issuecomment-
> > 377478105>,
> > > or mute the thread
> > > <https://github.com/notifications/unsubscribe-auth/
> > AAF05Bib8LKqnSW1gbi6MeVJBeMM02Z1ks5tje4hgaJpZM4TBJTP>
> > > .
> > >
> >
> > —
> > You are receiving this because you commented.
> > Reply to this email directly, view it on GitHub
> > <#66 (comment)-
> 377527357>,
> > or mute the thread
> > <https://github.com/notifications/unsubscribe-auth/
> AAktujEmTkWk09qnuJcDFbuP6qvSkvqwks5tjjctgaJpZM4TBJTP>
> > .
> >
>
>
>
> --
> Regards,
> *杨博 Yang Bo*
> *Consultant, ThoughtWorks*
> [image: ThroughtWorks]
> <https://www.thoughtworks.com/profiles/yang-bo-yangbo>
> <https://github.com/Atry> [image: Blog]
> <http://www.ac.net.blog.163.com/> [image:
> 知乎] <https://www.zhihu.com/people/atry>
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#66 (comment)-
377799013>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/
AAF05PgULRLdhkxgOHc5vwvq5n4ODWVhks5tkQIDgaJpZM4TBJTP>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#66 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAktuj245mFWJ4O4vFLbYGPkGkrr_O_3ks5tkWP8gaJpZM4TBJTP>
.
--
杨博 (Yang Bo)
|
See https://github.com/ThoughtWorksInc/dsl-domains-cats Cats support for Dsl.scala
See https://github.com/ThoughtWorksInc/dsl-domains-cats for Cats support for Dsl.scala
The cats library has been moved to a separate repository https://github.com/ThoughtWorksInc/dsl-domains-cats |
Move domains-cats to another repository (related to #66)
Currently, DSL bundles alot of loosely related functionality together. I would like to access the !-notation feature in a modular way.
I didn't grasp the benefits of the !-notation when you first presented at REA FP guild (in the Each project), but I have since better understood the potential and would like to trial it. I write mostly monadic code nowadays, so any way to reduce "friction" can have a big payoff.
However, Im not going to take such big dependency as whole of DSL ATM, but if !-notation was more modular I would try using it (Ive been burned by large codebase dependencies in the past, most notably Finagle which didnt support 2.11.x for ages, just because some small parts of it didnt).
Please consider splitting out !-notation and supporting machinery (eg reset all plugin) into separate repos/artifacts.
The text was updated successfully, but these errors were encountered: