Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArtifactCatalog SystemInitializer is called too early #28

Open
VarnaScelestus opened this issue Apr 11, 2022 · 1 comment
Open

ArtifactCatalog SystemInitializer is called too early #28

VarnaScelestus opened this issue Apr 11, 2022 · 1 comment
Labels
bug Something isn't working cantfix/wontfix This issue is implausible or impossible to fix, or out of the project's scope compatibility Integration request/incompatibility report for another mod

Comments

@VarnaScelestus
Copy link

Something in the mod causes the SystemInitializer to activate too soon for ArtifactCatalog, causing all mods that are loaded after TILER2 that depend on that functionality to break.

Bubbet (in the modding discord) ran into a similar issue in one of his mods where this happened because he was using a Harmony patch in the same class as a SystemInitializer. Not sure if you're doing the same but I thought it might be a good starting point to mention.
@ThinkInvis ThinkInvis added unconfirmed-bug Testing needs to be performed to confirm this bug compatibility Integration request/incompatibility report for another mod labels Apr 11, 2022
@ThinkInvis ThinkInvis added bug Something isn't working cantfix/wontfix This issue is implausible or impossible to fix, or out of the project's scope and removed unconfirmed-bug Testing needs to be performed to confirm this bug labels Apr 20, 2022
@ThinkInvis
Copy link
Owner

ThinkInvis commented Apr 20, 2022 •
edited
Loading

This is an issue with how SystemInitializer scanning works. It needs to be changed to handle an exception caused by any mod that has a missing soft dependency. R2API or RoR2BepInExPack might have a fix for it now or soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working cantfix/wontfix This issue is implausible or impossible to fix, or out of the project's scope compatibility Integration request/incompatibility report for another mod
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ThinkInvis @VarnaScelestus