Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing item/equipment disable status midgame does not update logbook #23

Open
ThinkInvis opened this issue Mar 14, 2022 · 0 comments
Open
Labels
bug Something isn't working

Comments

@ThinkInvis
Copy link
Owner

Describe the Bug

Disabling/enabling an item or equipment while the game is running should cause its entry to disappear/appear in the logbook, respectively. Due to code limitations (relevant data is stored in ReadOnlyCollections in ViewablesCatalog), this has not been accomplished yet.

To Reproduce

  1. Launch the game with TILER2 and a dependent item mod installed (with all items enabled)
  2. Open the logbook menu
  3. Observe a modded item in the logbook
  4. Disable the modded item (via console ncfg set itemname enabled false)
  5. Observe that the modded item's logbook entry has not disappeared, even after closing and reopening the logbook
  6. Restart the game
  7. Open the logbook menu
  8. Observe that the modded item's logbook entry is hidden

Expected Behavior

Logbook entry hide state should be refreshed upon opening the logbook, instead of only when the game is loaded. Ideally, a change in hide state should reload the logbook if it's already open.

@ThinkInvis ThinkInvis added the bug Something isn't working label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant