Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getDaysToDelivery Function Returns Positive When Should Be Negative #2

Open
Nerwyn opened this issue Nov 9, 2021 · 1 comment
Open

getDaysToDelivery Function Returns Positive When Should Be Negative #2

Nerwyn opened this issue Nov 9, 2021 · 1 comment

Comments

@Nerwyn
Copy link

Nerwyn commented Nov 9, 2021

getDaysToDelivery function in /src/components/05_VinDetailsView.vue always returns a positive number, even when the delivery date has passed. At line 262 there shouldn't be a Math.abs call. Negative numbers are already being caught in checkDaysToDelivery and should be returned as "N/A".

Reporting because my Mach E is over a week late at this point and I got false hope from incorrect days to delivery 😢.
@Nerwyn
Copy link
Author

Nerwyn commented Nov 9, 2021

There's already a PR to fix this that needs approval too: #1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Nerwyn