Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P1967 - #embed #29

Open
ThePhD opened this issue Apr 4, 2020 · 11 comments
Open

P1967 - #embed #29

ThePhD opened this issue Apr 4, 2020 · 11 comments
Assignees
Labels
dwarves [wording.cwg] Core Wording Group, the dwarves, who cast the words and capture the imagination into Standard Steel.
Milestone

Comments

@ThePhD
Copy link
Owner

ThePhD commented Apr 4, 2020

#embed is a pre-processor directive for the inclusion of binary data into a program through implementation-defined resource lookup.

Latest draft is: https://thephd.github.io/vendor/future_cxx/papers/source/C%20-%20embed

@ThePhD ThePhD added the wg14 Proposals targeting the C Standards Committee, rather than C++ label Apr 4, 2020
@ThePhD ThePhD added this to the C2x milestone Apr 4, 2020
@ThePhD ThePhD self-assigned this Apr 4, 2020
@ThePhD
Copy link
Owner Author

ThePhD commented Apr 4, 2020

I now have to figure out how

#embed [bits-per-element]opt [max-elements]opt header-name

can be done. Disambiguation of the numeric constant for bits-per-element versus max-elements means you cannot specify just one of them and have the preprocessor know which one...

@ThePhD
Copy link
Owner Author

ThePhD commented Sep 25, 2020

This paper is on track. The next time it is seen it will just be

#embed [max-elements]opt header-name

It will always produce a comma-delimited sequence of unsigned char. Just need to update the paper now.

@ThePhD
Copy link
Owner Author

ThePhD commented Nov 22, 2020

@ThePhD ThePhD changed the title P1967 / n2499 - #embed P1967 / n2592 - #embed Nov 22, 2020
@ThePhD
Copy link
Owner Author

ThePhD commented Dec 5, 2020

The wording needed a lot of work, so we fixed it up quite a bit:

https://thephd.github.io/_vendor/future_cxx/papers/C%20-%20embed.html

@ThePhD ThePhD added the orcs [design.ewg] To be mulled over by the rowdy, unpredictable, rambunctious featureists in Evolution. label Dec 5, 2020
@ThePhD
Copy link
Owner Author

ThePhD commented Apr 16, 2021

@vegard
Copy link

vegard commented Jun 19, 2021

Not sure where to best put this, but I found this issue so I'll comment here. Comments apply to draft proposal of June 15, 2021.

  • 2.1 "Others pointed out that ... is very dangerous to portably." Should be "portability"?
  • 2.2 The link to std::embed displays the markdown source in the rendered document
  • 3.2.1 "Speed Size". Should this just be "Speed"?
  • 3.2.3 "require an extremely large refactor and functionality add of parser internals" Not sure "add" is the right word here?
  • 4.4 "casted" should probably just be "cast"
  • 4.6 you probably also want to #include <cstdio> if you're including includes in the example
  • 4.6 the section talks about fread() into an array of ints, but the example uses unsigned char
  • 8 the the includecpp.org link is also not rendered correctly
  • 9.1.4 the incbin link isn't rendered correctly
  • 9.2 at the end "the proposal now let’s the implementation "figure it out"" should be "lets" without the apostrophe

When I refer to links that don't render correctly, this is the document I'm looking at: https://thephd.dev/_vendor/future_cxx/papers/d1967.html

@ThePhD
Copy link
Owner Author

ThePhD commented Jun 19, 2021

Thanks for looking out; these have all been edited / fixed.

@ThePhD
Copy link
Owner Author

ThePhD commented Jun 19, 2021

C++ paper has been split off into it's own thing. Which looks prettier because it uses bikeshed now:

https://thephd.dev/_vendor/future_cxx/papers/d1967.html

@ThePhD
Copy link
Owner Author

ThePhD commented Apr 11, 2022

C++ and C papers have been properly split up. Wording is based on which link you travel:

https://thephd.dev/_vendor/future_cxx/papers/d1967.html
https://thephd.dev/_vendor/future_cxx/papers/C%20-%20embed.html

@ThePhD ThePhD changed the title P1967 / n2592 - #embed P1967 / n3000 - #embed Jun 20, 2022
@ThePhD
Copy link
Owner Author

ThePhD commented Aug 10, 2022

Added to C23; only C++26 part left.

@ThePhD ThePhD changed the title P1967 / n3000 - #embed P1967 - #embed Aug 10, 2022
@ThePhD ThePhD removed the wg14 Proposals targeting the C Standards Committee, rather than C++ label Aug 10, 2022
@ThePhD ThePhD modified the milestones: C23, C++26 Aug 10, 2022
@ThePhD
Copy link
Owner Author

ThePhD commented Jan 14, 2024

Submitted the latest for this: https://wg21.link/p1967r12

@ThePhD ThePhD added dwarves [wording.cwg] Core Wording Group, the dwarves, who cast the words and capture the imagination into Standard Steel. and removed orcs [design.ewg] To be mulled over by the rowdy, unpredictable, rambunctious featureists in Evolution. labels Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dwarves [wording.cwg] Core Wording Group, the dwarves, who cast the words and capture the imagination into Standard Steel.
Projects
None yet
Development

No branches or pull requests

2 participants