Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should tests that test multiple things be broken into individual files? #24

Open
dstorey opened this issue Feb 1, 2016 · 1 comment

Comments

@dstorey
Copy link
Contributor

dstorey commented Feb 1, 2016

Currently a number of test files include a few tests. An example would be header, for when it is the root header that should get the banner role, and the nested header that shouldn't. Another would be sub and sup being in the same file.

Should we break these up into one pass/fail test per file, so that it is easier for implementers, and clearer if a full test case passes or fails? It would make the resources section clearer too, as it'd only include the spec link for the one thing being tested.

@stevefaulkner
Copy link
Contributor

Should we break these up into one pass/fail test per file, so that it is easier for implementers, and clearer if a full test case passes or fails?

sure, there are some tests such as the table tests which could be broken down further also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants