Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARC Toolkit fails to scan content within iframes when the tool is kept oven between scans #60

Open
JesusGonzalezA opened this issue May 15, 2024 · 5 comments

Comments

@JesusGonzalezA
Copy link

JesusGonzalezA commented May 15, 2024

Describe the bug

ARC Toolkit is not able to evaluate pages containing an iframe when the tool is kept open and it is not its first scan.

To Reproduce

Using a CHROME browser with ARC Toolkit installed and enabled

  • Go to minimal case
  • Open ARC Toolkit and click Run Tests. An error appears (No label for button element).
  • Keep the dev tools open and click the link "Opens this page without a parent"
  • When the screen loads, click Run Tests in ARC Toolkit again. The error appears again (No label for button element).
  • Keep the dev tools open and click the link "Go to parent page containing this iframe"
  • When the screen loads, click Run Tests in ARC Toolkit again. The error does not appear (it should).

Test Case (CodePen/JSBin/etc.): minimal case

Expected behavior

ARC Toolkit detects the error in all scenarios. The results should be consistent.

Screenshots

Version information

Browser and version: 124.0.6367.158 (Build oficial) (64 bits) (cohort: Control)
ARC Toolkit version: 5.7.1
Additional context

@ferllings
Copy link
Member

So far I'm not able to reproduce

@JesusGonzalezA
Copy link
Author

I'm sorry, the link I provided was not the correct one. I've updated the description. In any other case, check it here
minimal case.

I add a gif as well where I reproduce the indicated steps and demonstrate the error, just in case it helps :)
Reproducing the error

@ferllings
Copy link
Member

@JesusGonzalezA still the same link: I can't reproduce

@JesusGonzalezA
Copy link
Author

Hi @ferllings,
I'm still able to reproduce the issue with that link. I found an easier way to reproduce it:

  1. Go to minimal case
  2. Run ARC. An error appears (No label for element)
  3. Keep ARC open. Refresh the page.
  4. Run ARC again. The error does not appear.

Although it is scanning the same page, the scan is not consistent, as the second time the error does not appear in the tool.

@ferllings
Copy link
Member

Thanks. I'm able to reproduce if I disable the cache.
Might be some sort of race condition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants