Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUNDATIONS: Check PR Title Job #95

Closed
wants to merge 2 commits into from

Conversation

cjdutoit
Copy link
Collaborator

@cjdutoit cjdutoit commented Dec 27, 2023

This job will checkout that a PR has been created with one of THE STANDARD accepted categories mentioned here:
https://github.com/hassanhabib/The-Standard-Team/blob/main/4%20Practices/4%20Practices.md#4113-category-list

                Jobs = new Dictionary<string, Job>
                {
                    {
                        "check_pr_title",
                        new CheckPrTitleJob(
                            runsOn: BuildMachines.UbuntuLatest)
                    },
                    {
                        "build",
                        new Job
                        {
                            Needs = new string[] { "check_pr_title" },
                            . . . 
                        }
                    }
                }

STEPS:

  • Add the "check_pr_title" job before existing jobs
  • Optionally add Needs = new string[] { "check_pr_title" }, to the job after this one, this will stop processing of subsequent jobs on fail.

Sample success message
image

image

Sample error message
image

@hassanhabib
Copy link
Member

@ElbekDeveloper is this a toaster?

@glhays
Copy link
Member

glhays commented Jan 7, 2024

@hassanhabib, @cjdutoit, @ElbekDeveloper
Docs need to align, when branch naming we use a mix of singularity and plurals, when naming a pull request here(see pr commits), we appear to be using only singular category names.
It becomes hard to assist new comers to The Standard when these mixed signals are out there.

image

image

@cjdutoit
Copy link
Collaborator Author

@hassanhabib, @cjdutoit, @ElbekDeveloper Docs need to align, when branch naming we use a mix of singularity and plurals, when naming a pull request here(see pr commits), we appear to be using only singular category names. It becomes hard to assist new comers to The Standard when these mixed signals are out there.

image

image

Hi @glhays / @hassanhabib / @ElbekDeveloper, this was done on purpose to closely match GitFyle, but happy to change this to plural version only as long as that is supported by GitFyle.

@cjdutoit cjdutoit added the FOUNDATIONS The foundations category label May 21, 2024
@cjdutoit cjdutoit closed this Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FOUNDATIONS The foundations category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants