Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coding an elegant Rooms Listing Page #6

Open
SatvikDandale opened this issue Dec 26, 2020 · 2 comments
Open

Coding an elegant Rooms Listing Page #6

SatvikDandale opened this issue Dec 26, 2020 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@SatvikDandale
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Our Current rooms page is good, but we feel we can surely make it better, more professional, and elegant. Design new Rooms Listing page for the platform.

**What features does our page have? **
The Rooms page currently lists two tables, one for all the rooms, public/private, and the other, for which the user is a member.

What features do we want extra?
The following features are expected from the new Rooms Page:

These are only design/frontend features, which will not work with APIs or any other integration. The integration task will be assigned after this issue gets closed.

  1. The rooms page should be responsive and will show both tables as per the screen size.
  2. Both tables should have details like Room Name, Creator, Status (public/private), etc.
  3. The page should handle errors using snackbar.
  4. Both tables should have independent loading/progress animation.
  5. Pagination for larger tables (Optional)

How should you submit a pull request for this issue

  1. Fork this repo and create a new route /rooms1 inside your react-router.
  2. Deploy your repo at Heroku/Netlify or any other place you are comfortable with.
  3. Comment your deployed app link in this issue comment.
  4. If your design is approved by the mentor, send a pull request as guidelines given in the readme file for frontend
  5. Make sure your page uses this color scheme https://colorhunt.co/palette/2763

Any tips for solving this issue
Using React Material-UI for this task will be highly recommended as the components from Material-UI are clean and elegant.

@SatvikDandale SatvikDandale added enhancement New feature or request good first issue Good for newcomers labels Dec 26, 2020
@Akanksha7-art
Copy link

Can I go ahead with this?_

@nikhilbghodke
Copy link
Contributor

Hey Akanksha,
Just Follow the guidelines given in the issue and documentation and then you are good to go for this issue.
You are free to use any open sourced template provided your design is professional and responsive.
if your design is approved my mentors, then it will be merged with the codebase.
Happy learning :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants