Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license information and other details for flow/designs/src/* #26

Open
asb opened this issue Aug 8, 2019 · 3 comments
Open

Add license information and other details for flow/designs/src/* #26

asb opened this issue Aug 8, 2019 · 3 comments
Labels
documentation Improvements or additions to documentation license Relates to licensing

Comments

@asb
Copy link

asb commented Aug 8, 2019

It would be great to add more info to flow/designs/src/*. At a minimum - ideally a link to the upstream project, the commit hash used to produce the .v, and ideally more info about how it was generated (e.g. what options were used). You should also import a copy of any license text and other attribution information, as most open source licenses require this.

[Really pleased to see you using Ibex as a benchmark for OpenROAD by the way - and looking forward to finding time to give the flow a go].

@tajayi tajayi added documentation Improvements or additions to documentation license Relates to licensing labels Aug 8, 2019
@tajayi
Copy link
Contributor

tajayi commented Aug 8, 2019

Thanks for the feedback. I'll try to add this. Some designs needed to be "elaborated" using a different tool because Yosys doesn't currenty support system verilog so we may not be able to have it in it's original form.

But we should be able to provide trace-ability, license and information to how the verilog sources files were generated.

@tajayi
Copy link
Contributor

tajayi commented Aug 9, 2019

I've started going through some of the designs and adding the requested information. I've done so for ibex. Let me know if this looks good.

@asb
Copy link
Author

asb commented Aug 9, 2019

Information on commit hash, how it was produced etc is a huge improvement - thanks! I'm not a lawyer, but including the original license also seems like a big step forward there. Thanks for such a rapid turnaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation license Relates to licensing
Projects
None yet
Development

No branches or pull requests

2 participants