From 25335ab539cc3a4aed3bfd3ffa2a042ee4daa7a6 Mon Sep 17 00:00:00 2001
From: Silvio Hermann <s.hermann@uni-jena.de>
Date: Tue, 10 Sep 2024 09:41:00 +0200
Subject: [PATCH] #550 Made type of HISinOne servflag configurable

---
 .../de/uni_jena/thunibib/his/xml/HISInOneServiceFlag.java   | 6 +++++-
 .../main/resources/config/thunibib-common/mycore.properties | 1 +
 .../resources/xsl/mycoreobject-mods-resolve-his-keys.xsl    | 6 +++---
 3 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/common/src/main/java/de/uni_jena/thunibib/his/xml/HISInOneServiceFlag.java b/common/src/main/java/de/uni_jena/thunibib/his/xml/HISInOneServiceFlag.java
index 439814fb1..d730a7274 100644
--- a/common/src/main/java/de/uni_jena/thunibib/his/xml/HISInOneServiceFlag.java
+++ b/common/src/main/java/de/uni_jena/thunibib/his/xml/HISInOneServiceFlag.java
@@ -1,10 +1,14 @@
 package de.uni_jena.thunibib.his.xml;
 
+import org.mycore.common.config.MCRConfiguration2;
+
 public class HISInOneServiceFlag {
+    static final String SERVFLAG_TYPE = MCRConfiguration2.getStringOrThrow("ThUniBib.HISinOne.servflag.type");
+
     private HISInOneServiceFlag() {
     }
 
     public static String getName() {
-        return "his-id";
+        return HISInOneServiceFlag.SERVFLAG_TYPE;
     }
 }
diff --git a/common/src/main/resources/config/thunibib-common/mycore.properties b/common/src/main/resources/config/thunibib-common/mycore.properties
index 1b8087a28..28b2ba1e2 100644
--- a/common/src/main/resources/config/thunibib-common/mycore.properties
+++ b/common/src/main/resources/config/thunibib-common/mycore.properties
@@ -159,6 +159,7 @@ ThUniBib.HISinOne.BaseURL                                               = https:
 ThUniBib.HISinOne.BaseURL.API.Path                                      = api/v1/
 ThUniBib.HISinOne.ClientKey                                             =
 ThUniBib.HISinOne.ClientSecret                                          =
+ThUniBib.HISinOne.servflag.type                                         = MyCoRe-HISinOne
 
 ThUniBib.HISinOne.Publication.Transformer.Name                          = res-publication-json-detailed
 ThUniBib.HISinOne.Journal.Transformer.Name                              = res-json-journal-base
diff --git a/common/src/main/resources/xsl/mycoreobject-mods-resolve-his-keys.xsl b/common/src/main/resources/xsl/mycoreobject-mods-resolve-his-keys.xsl
index b1cd25e66..3c674e393 100644
--- a/common/src/main/resources/xsl/mycoreobject-mods-resolve-his-keys.xsl
+++ b/common/src/main/resources/xsl/mycoreobject-mods-resolve-his-keys.xsl
@@ -14,6 +14,7 @@
   <xsl:param name="MCR.user2.matching.lead_id"/>
   <xsl:param name="ThUniBib.HISinOne.BaseURL"/>
   <xsl:param name="ThUniBib.HISinOne.BaseURL.API.Path"/>
+  <xsl:param name="ThUniBib.HISinOne.servflag.type"/>
   <xsl:param name="WebApplicationBaseURL"/>
 
   <xsl:variable name="origin" select="document('classification:metadata:-1:children:ORIGIN')/mycoreclass/categories" />
@@ -332,10 +333,9 @@
     </xsl:copy>
   </xsl:template>
 
-  <xsl:template match="//servflags[servflag[@type = 'his-id']]">
+  <xsl:template match="//servflags[servflag[@type = $ThUniBib.HISinOne.servflag.type]]">
     <xsl:copy>
       <xsl:copy-of select="*|@*"/>
-      <xsl:variable name="hisid" select="servflag[@type = 'his-id']"/>
       <xsl:variable name="genre" select="fn:substring-after(//mycoreobject//mods:mods/mods:genre[@type='intern']/@valueURI, '#')"/>
 
       <xsl:variable name="lockVersion">
@@ -349,7 +349,7 @@
         </xsl:choose>
       </xsl:variable>
 
-      <servflag type="his-id-lockVersion">
+      <servflag type="{$ThUniBib.HISinOne.servflag.type}-lockVersion">
         <xsl:value-of select="$lockVersion"/>
       </servflag>
     </xsl:copy>