fix: ensure FlushAsync behaves like Flush (#960)

Added an overwrite for `Stream.FlushAsync` to the `MockFileStream` class, which ensures that the internal flush implementation is called. This way `FlushAsync` will correctly project the changes to the underlying `MockFile`, exactly like `Flush` does. Closes #959
TestableIO · Mar 13, 2023 · 2b6dba4 · 2b6dba4
1 parent 9dc2c3a
commit 2b6dba4
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 0 deletions.
diff --git a/src/TestableIO.System.IO.Abstractions.TestingHelpers/MockFileStream.cs b/src/TestableIO.System.IO.Abstractions.TestingHelpers/MockFileStream.cs
@@ -198,6 +198,13 @@ public override void Flush()
             InternalFlush();
         }
 
+        /// <inheritdoc />
+        public override Task FlushAsync(CancellationToken cancellationToken)
+        {
+            InternalFlush();
+            return Task.CompletedTask;
+        }
+
         /// <inheritdoc cref="IFileSystemAclSupport.GetAccessControl()" />
         [SupportedOSPlatform("windows")]
         public object GetAccessControl()

diff --git a/tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockFileStreamTests.cs b/tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockFileStreamTests.cs
@@ -1,6 +1,7 @@
 namespace System.IO.Abstractions.TestingHelpers.Tests
 {
     using System.Collections.Generic;
+    using System.Threading.Tasks;
 
     using NUnit.Framework;
 
@@ -27,6 +28,27 @@ public void MockFileStream_Flush_WritesByteToFile()
             CollectionAssert.AreEqual(new byte[] { 255 }, fileSystem.GetFile(filepath).Contents);
         }
 
+        [Test]
+        public async Task MockFileStream_FlushAsync_WritesByteToFile()
+        {
+            // bug replication test for issue
+            // https://github.com/TestableIO/System.IO.Abstractions/issues/959
+
+            // Arrange
+            var filepath = XFS.Path(@"C:\something\foo.txt");
+            var fileSystem = new MockFileSystem(new Dictionary<string, MockFileData>());
+            fileSystem.AddDirectory(XFS.Path(@"C:\something"));
+
+            var cut = new MockFileStream(fileSystem, filepath, FileMode.Create);
+
+            // Act
+            await cut.WriteAsync(new byte[] { 255 }, 0, 1);
+            await cut.FlushAsync();
+
+            // Assert
+            CollectionAssert.AreEqual(new byte[] { 255 }, fileSystem.GetFile(filepath).Contents);
+        }
+
         [Test]
         public void MockFileStream_Dispose_ShouldNotResurrectFile()
         {