Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to ignore assembly versions where comparing #13

Open
kkozmic opened this issue Jul 28, 2013 · 2 comments
Open

Add option to ignore assembly versions where comparing #13

kkozmic opened this issue Jul 28, 2013 · 2 comments

Comments

@kkozmic
Copy link
Contributor

kkozmic commented Jul 28, 2013

When generating approvals file that contains type names the fully qualified name of types can change (common case is every build from TeamCity generating a new version number). This may lead to Approvals failing since at the text level, they are different.

An option to ignore/swap assembly version (version=x.x.x.x) would be helpful for those cases

@JakeGinnivan
Copy link
Member

I think the output should not include the version number, each convention should make sure that it doesn't output any version of other data that may change

@kkozmic
Copy link
Contributor Author

kkozmic commented Aug 6, 2013

I agree for the default conventions.

This is also about providing helper API for people building their own to be able to use assembly qualified name if they wish so, but with version replacement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants