Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Untangle session/client ID snarl in gateway #419

Open
Terkwood opened this issue Oct 23, 2020 · 0 comments
Open

Untangle session/client ID snarl in gateway #419

Terkwood opened this issue Oct 23, 2020 · 0 comments
Labels
tech-debt Lib upgrades, Carryover from prior decisions, &c

Comments

@Terkwood
Copy link
Owner

Terkwood commented Oct 23, 2020 •
edited
Loading

SessionId and ClientId are type aliases to Uuid in gateway. It comes as no surprise that we most likely made a mistake and switched them up at some point in the code base 🤓

Try to untangle them without destroying the system's (apparent) functionality. We should use strongly-typed identifiers, as we do in the other projects... and preferably just use core-model --- which would allow us to destroy a lot of conversion code in gateway as a side victory

https://github.com/Terkwood/BUGOUT/tree/tinker/mega-refactor
@Terkwood Terkwood added the tech-debt Lib upgrades, Carryover from prior decisions, &c label Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech-debt Lib upgrades, Carryover from prior decisions, &c
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Terkwood